Super Mario Bros. - 128 Lives Fix

[SparTonberry]

Why would you LDA and INC the number of lives in that second example? It's pointless.

[ColecoFan1981]

Why would you LDA and INC the number of lives in that second example? It's pointless.

The same would apply to the first example, too... I too would like to know why not to INC right after LDA? It might be because INC is like LDA #$01+STA.

A better way to do this would be:

CheckLives:
    lda NumberofLives ;load the lives counter
    cmp #$7f          ;check if player has 127 lives
    bcs EndCheckL     ;skip to end of routine if so
    inc NumberofLives ;otherwise increment counter by one
EndCheckL:
    rtl

Saves a lot of bytes.

Another way...

CheckLives:
    lda NumberofLives ;load the lives counter
    bmi EndCheckL     ;skip to end if negative flag set
    inc NumberofLives ;otherwise increment counter by one
EndCheckL:
    rtl

~Ben

[ColecoFan1981]

Why would you LDA and INC the number of lives in that second example? It's pointless.

OK, I fixed the examples I listed. In SMAS, the lives counter is incremented first, and then reloaded to see if the target result has been met.

~Ben